public class Main { private static byte STX = 0x02; // 2 开始位 //private static byte Rand = AccesscEntrty.ACCRandom();//随机数 public static void main(String[] args) { Main dynamicBuffer = new Main(); dynamicBuffer.put(new byte[] {STX,0x2C}); byte[] result = dynamicBuffer.toArray(); for (byte b : result) { System.out.println(b); } } private static final int INITIAL_SIZE = 9; private byte[] data; private ByteBuffer byteBuffer; public void DynamicByteBuffer() { data = new byte[INITIAL_SIZE]; byteBuffer = ByteBuffer.wrap(data); } public void put(byte[] newData) { int requiredCapacity = byteBuffer.position() + newData.length; if (requiredCapacity > data.length) { int newSize = Math.max(data.length * 2, requiredCapacity); byte[] newDataArray = new byte[newSize]; System.arraycopy(data, 0, newDataArray, 0, byteBuffer.position()); data = newDataArray; byteBuffer = ByteBuffer.wrap(data); } byteBuffer.put(newData); } public byte[] toArray() { return Arrays.copyOf(data, byteBuffer.position()); } }为什么运行错误哪里可以改进
时间: 2024-01-23 11:03:35 浏览: 135
STb7100MB.zip_OA系统_C/C++_
该代码存在以下问题:
1. `DynamicByteBuffer()` 方法名应该改为构造方法名 `Main()`;
2. `Rand` 变量没有定义,可能会导致编译错误,建议注释掉该行代码;
3. `put()` 方法中的 `byteBuffer.put(newData)` 应该改为 `byteBuffer.put(newData, 0, newData.length)`,因为 `newData` 数组可能比 `byteBuffer` 剩余的空间大,这会导致 `BufferOverflowException` 异常;
4. `put()` 方法中的 `if (requiredCapacity > data.length)` 语句中的判断条件应该改为 `requiredCapacity > byteBuffer.capacity()`,因为 `data.length` 在之后可能被扩容,但是 `byteBuffer.capacity()` 不会改变。
下面是修改后的代码:
```java
import java.nio.ByteBuffer;
import java.util.Arrays;
public class Main {
private static byte STX = 0x02; // 2 开始位
//private static byte Rand = AccesscEntrty.ACCRandom();//随机数
public static void main(String[] args) {
Main dynamicBuffer = new Main();
dynamicBuffer.put(new byte[] {STX, 0x2C});
byte[] result = dynamicBuffer.toArray();
for (byte b : result) {
System.out.println(b);
}
}
private static final int INITIAL_SIZE = 9;
private byte[] data;
private ByteBuffer byteBuffer;
public Main() {
data = new byte[INITIAL_SIZE];
byteBuffer = ByteBuffer.wrap(data);
}
public void put(byte[] newData) {
int requiredCapacity = byteBuffer.position() + newData.length;
if (requiredCapacity > byteBuffer.capacity()) {
int newSize = Math.max(byteBuffer.capacity() * 2, requiredCapacity);
byte[] newDataArray = Arrays.copyOf(data, newSize);
byteBuffer = ByteBuffer.wrap(newDataArray);
byteBuffer.position(data.length);
}
byteBuffer.put(newData, 0, newData.length);
}
public byte[] toArray() {
return Arrays.copyOf(data, byteBuffer.position());
}
}
```
阅读全文