优化以下代码public void take_photo(View view) { Toast.makeText(this,"打开相机",Toast.LENGTH_SHORT).show(); Intent takePictureIntent = new Intent(MediaStore.ACTION_IMAGE_CAPTURE); // takePictureIntent.addCategory(Intent.CATEGORY_DEFAULT); if (takePictureIntent.resolveActivity(getPackageManager()) != null) { File photoFile = null; try { photoFile = createImageFile(); } catch (IOException ex) { ex.printStackTrace(); } if (photoFile != null) { Uri photoURI = FileProvider.getUriForFile(this, "com.example.android.fileprovider", photoFile); takePictureIntent.putExtra(MediaStore.EXTRA_OUTPUT, photoURI); startActivityForResult(takePictureIntent, 1);
时间: 2023-06-09 10:08:54 浏览: 531
这段代码具有一定的复杂性和冗余性,可以进行以下优化:
1. 将Toast的提示信息放在拍照成功后再显示,可以让用户更直观地了解拍照结果;
2. 可以将拍照Intent的创建和执行分开,以减少创建过程中的异常风险;
3. 可以删除多余的注释和未使用的代码,使代码更加简洁。
下面是优化后的代码:
public void take_photo(View view) {
Intent takePictureIntent = new Intent(MediaStore.ACTION_IMAGE_CAPTURE);
File photoFile = null;
try {
photoFile = createImageFile();
} catch (IOException ex) {
ex.printStackTrace();
}
if (photoFile != null) {
Uri photoURI = FileProvider.getUriForFile(this,
"com.example.android.fileprovider", photoFile);
takePictureIntent.putExtra(MediaStore.EXTRA_OUTPUT, photoURI);
startActivityForResult(takePictureIntent, 1);
}
}
@Override
protected void onActivityResult(int requestCode, int resultCode, Intent data) {
super.onActivityResult(requestCode, resultCode, data);
if (requestCode == 1 && resultCode == RESULT_OK) {
Toast.makeText(this, "拍照成功", Toast.LENGTH_SHORT).show();
}
}
阅读全文
相关推荐












