const processSaleBoundArr = async (saleBoundArr, tokenData, accountData) => { let saleOutBounds = [] if (saleBoundArr?.length > 0) { let customerIds = [], customArr = [] for (const item of saleBoundArr) { customerIds.push(item.customer_id) customerIds = Array.from(new Set(customerIds)); } for (const i of customerIds) { const customerDetailRes = await getCustomerDetail( { id: i }, { "app-token": tokenData['app-token'], "X-GW-Router-Addr": accountData?.domain } ); if (customerDetailRes.data.errcode === 0) { const customerData = customerDetailRes.data.data customArr.push(customerData) } } for (const s of saleBoundArr) { for (const c of customArr) { if (s.customer_id === c.customer_id) { s.account_open_addr = c.account_open_addr s.addr = c.addr s.bank = c.bank s.bank_account = c.bank_account s.taxpayer_no = c.taxpayer_no s.orgName = c.sale_dept_name saleOutBounds.push(s) } } } } return saleOutBounds } 优化代码
时间: 2024-03-08 07:51:02 浏览: 80
以下是对上述代码的优化建议:
1. 对于 `saleBoundArr?.length > 0` 这个条件判断,可以使用 `if (saleBoundArr && saleBoundArr.length)` 来代替,更加简洁明了。
2. 在获取客户详细信息的过程中,可以使用 `Promise.all()` 方法并行获取多个客户的详细信息,避免顺序执行耗费时间。
3. 可以使用 `Array.prototype.find()` 方法代替双重循环查找客户详细信息,提高查找效率。
4. 在获取客户详细信息时,可以使用 `map()` 方法将客户 `id` 数组转换为客户详细信息数组,避免使用多次 `push()` 方法。
下面是优化后的代码示例:
```javascript
const processSaleBoundArr = async (saleBoundArr, tokenData, accountData) => {
let saleOutBounds = [];
if (saleBoundArr && saleBoundArr.length) {
const customerIds = [...new Set(saleBoundArr.map(item => item.customer_id))];
const customerPromises = customerIds.map(id => {
return getCustomerDetail(
{ id },
{ "app-token": tokenData['app-token'], "X-GW-Router-Addr": accountData?.domain }
);
});
const customerDetails = await Promise.all(customerPromises);
saleOutBounds = saleBoundArr.map(saleBound => {
const customerDetail = customerDetails.find(detail => detail.data.errcode === 0 && detail.data.data.customer_id === saleBound.customer_id);
if (customerDetail) {
const customerData = customerDetail.data.data;
saleBound.account_open_addr = customerData.account_open_addr;
saleBound.addr = customerData.addr;
saleBound.bank = customerData.bank;
saleBound.bank_account = customerData.bank_account;
saleBound.taxpayer_no = customerData.taxpayer_no;
saleBound.orgName = customerData.sale_dept_name;
}
return saleBound;
});
}
return saleOutBounds;
};
```
这个优化后的代码使用了一些 JavaScript 的高级语法,如 `Promise.all()` 和 `Array.prototype.find()` 方法,使代码更加简洁高效。
阅读全文