优化 if (!CrowdClassifyList.isEmpty() && CrowdClassifyList.size() != 0) { CrowdClassifyList.forEach(k -> { Integer tnb = k.getTnb(); Integer gxy = k.getGxy(); Date diabetesTime = k.getTnbXcsfJzsj20(); if (diabetesTime != null) { int dateAnddiabetesTime = date.compareTo(diabetesTime); if (Objects.equals(1, tnb) && dateAnddiabetesTime < 0) { k.setTnbStatus("糖"); } else if (Objects.equals(1, tnb) && dateAnddiabetesTime >= 0) { k.setTnbStatus("糖随"); } } Date hypertensionTime = k.getGxyXcsfJzsj20(); if (hypertensionTime != null) { int dateAndhypertensionTime = date.compareTo(hypertensionTime); if (Objects.equals(1, gxy) && dateAndhypertensionTime < 0) { k.setGxyStatus("高"); } else if (Objects.equals(1, gxy) && dateAndhypertensionTime >= 0) { k.setGxyStatus("高随"); } } String status = ""; if (!StringUtils.isEmpty(k.getTnbStatus())) { status = k.getTnbStatus(); } if (!StringUtils.isEmpty(k.getGxyStatus())) { status = k.getGxyStatus(); } if (!StringUtils.isEmpty(k.getTnbStatus()) && !StringUtils.isEmpty(k.getGxyStatus())) { status = k.getGxyStatus().concat(",").concat(k.getTnbStatus()); } k.setStatus(status); });
时间: 2023-12-28 21:03:23 浏览: 33
可以优化的地方有:
1. 使用 `List.isEmpty()` 替换 `CrowdClassifyList.size() != 0`
2. 将 `if (!CrowdClassifyList.isEmpty())` 和 `CrowdClassifyList.forEach(k -> {...})` 合并到一起
3. 将 `if (diabetesTime != null)` 和 `if (hypertensionTime != null)` 合并到一起
4. 将 `!StringUtils.isEmpty()` 替换为 `StringUtils.hasText()`
综上所述,可以将原始代码优化为如下形式:
```
if (!CrowdClassifyList.isEmpty()) {
CrowdClassifyList.forEach(k -> {
Integer tnb = k.getTnb();
Integer gxy = k.getGxy();
Date diabetesTime = k.getTnbXcsfJzsj20();
Date hypertensionTime = k.getGxyXcsfJzsj20();
if (diabetesTime != null || hypertensionTime != null) {
int dateAndTime = date.compareTo(diabetesTime != null ? diabetesTime : hypertensionTime);
if (Objects.equals(1, tnb) && diabetesTime != null && dateAndTime < 0) {
k.setTnbStatus("糖");
} else if (Objects.equals(1, tnb) && diabetesTime != null && dateAndTime >= 0) {
k.setTnbStatus("糖随");
}
if (Objects.equals(1, gxy) && hypertensionTime != null && dateAndTime < 0) {
k.setGxyStatus("高");
} else if (Objects.equals(1, gxy) && hypertensionTime != null && dateAndTime >= 0) {
k.setGxyStatus("高随");
}
}
String status = "";
if (StringUtils.hasText(k.getTnbStatus())) {
status = k.getTnbStatus();
}
if (StringUtils.hasText(k.getGxyStatus())) {
status = StringUtils.hasText(status) ? status + "," + k.getGxyStatus() : k.getGxyStatus();
}
k.setStatus(status);
});
}
```
以上优化方式主要是对代码风格和代码逻辑的调整,旨在提高代码可读性和性能。
相关推荐
![pdf](https://img-home.csdnimg.cn/images/20210720083512.png)
![pdf](https://img-home.csdnimg.cn/images/20210720083512.png)
![docx](https://img-home.csdnimg.cn/images/20210720083331.png)
![](https://csdnimg.cn/download_wenku/file_type_ask_c1.png)
![](https://csdnimg.cn/download_wenku/file_type_ask_c1.png)
![](https://csdnimg.cn/download_wenku/file_type_ask_c1.png)
![](https://csdnimg.cn/download_wenku/file_type_ask_c1.png)
![](https://csdnimg.cn/download_wenku/file_type_ask_c1.png)
![](https://csdnimg.cn/download_wenku/file_type_ask_c1.png)
![](https://csdnimg.cn/download_wenku/file_type_ask_c1.png)
![](https://csdnimg.cn/download_wenku/file_type_ask_c1.png)
![](https://csdnimg.cn/download_wenku/file_type_ask_c1.png)
![](https://csdnimg.cn/download_wenku/file_type_ask_c1.png)
![](https://csdnimg.cn/download_wenku/file_type_ask_c1.png)
![](https://csdnimg.cn/download_wenku/file_type_ask_c1.png)
![](https://csdnimg.cn/download_wenku/file_type_ask_c1.png)
![](https://csdnimg.cn/download_wenku/file_type_ask_c1.png)
![](https://csdnimg.cn/download_wenku/file_type_ask_c1.png)