改进代码t, _ := strconv.Atoi(ctx.Query("t")) switch t { case 1: req := models.Flaw{} case 2: req := models.Issue{} case 3: req := models.Record{} case 4: req := models.Quality{} case 5: req := models.Inspection{} } if err := ctx.ShouldBind(&req); err != nil { ctx.JSON(400, models.Response{ Code: 400, Msg: "参数有误", Data: err.Error(), }) return } res := common.DB.Create(&req)

可以将req的声明提前，这样就可以在后面的ctx.ShouldBind中使用了。另外，如果传入的t不是1-5的数字，也需要进行相应的错误处理。

改进代码如下：

t, err := strconv.Atoi(ctx.Query("t"))
if err != nil || t < 1 || t > 5 {
    ctx.JSON(400, models.Response{
        Code: 400,
        Msg:  "参数有误",
        Data: "t参数必须是1-5的数字",
    })
    return
}

var req interface{}
switch t {
case 1:
    req = &models.Flaw{}
case 2:
    req = &models.Issue{}
case 3:
    req = &models.Record{}
case 4:
    req = &models.Quality{}
case 5:
    req = &models.Inspection{}
}

if err := ctx.ShouldBind(req); err != nil {
    ctx.JSON(400, models.Response{
        Code: 400,
        Msg:  "参数有误",
        Data: err.Error(),
    })
    return
}

res := common.DB.Create(req)

相关问题

改进代码t, _ := strconv.Atoi(ctx.Query("t")) switch t { case 1: req := []*models.Flaw case 2: req := []*models.Issue case 3: req := []*models.Record case 4: req := []*models.Quality case 5: req := []*models.Inspection } if err := ctx.ShouldBind(&req); err != nil { ctx.JSON(400, models.Response{ Code: 400, Msg: "参数有误", Data: err.Error(), }) return } res := common.DB.Create(&req)

可以尝试将代码改为以下形式：

t, err := strconv.Atoi(ctx.Query("t"))
if err != nil {
    ctx.JSON(400, models.Response{
        Code: 400,
        Msg:  "参数有误",
        Data: err.Error(),
    })
    return
}

var req interface{}
switch t {
case 1:
    req = []*models.Flaw{}
case 2:
    req = []*models.Issue{}
case 3:
    req = []*models.Record{}
case 4:
    req = []*models.Quality{}
case 5:
    req = []*models.Inspection{}
default:
    ctx.JSON(400, models.Response{
        Code: 400,
        Msg:  "参数有误",
        Data: "请选择正确的类型",
    })
    return
}

if err := ctx.ShouldBind(&req); err != nil {
    ctx.JSON(400, models.Response{
        Code: 400,
        Msg:  "参数有误",
        Data: err.Error(),
    })
    return
}

res := common.DB.Create(req)

这样做的好处是：

- 将类型转换和请求体绑定分开处理，避免出现代码冗余或错误。
- 使用 `interface{}` 类型来接收不同类型的请求体，避免了类型转换的重复操作。
- 在 `switch` 语句中增加了默认分支，可以处理非法的类型参数。

改进代码func TracingList(ctx *gin.Context) { resp := models.Response{ Code: 0, Msg: "success", } t, _ := strconv.Atoi(ctx.Query("t")) label, _ := strconv.Atoi(ctx.Query("label")) page, _ := strconv.Atoi(ctx.DefaultQuery("page", "1")) pageSize, _ := strconv.Atoi(ctx.DefaultQuery("pageSize", "10")) code := ctx.Query("code") //设施类型 if len(code) == 0 { resp.Code = 400 resp.Msg = "请输入code值" ctx.JSON(400, resp) return } type Total struct { gorm.Model Type int16 Source int16 Explanation string Label int16 FacilityID string } db := common.DB.Session(&gorm.Session{}) if t < 0 || t > 5 { var req interface{} switch t { case 0: req = []*Total{} case 1: req = []*models.Flaw{} case 2: req = []*models.Issue{} case 3: req = []*models.Record{} case 4: req = []*models.Quality{} case 5: req = []*models.Inspection{} } //查询并分页 if t < 1 || t > 5 { res := db.Scopes(models.Paginate(page, pageSize)).Where("facility_id=?", code).Find(&req) if res.RowsAffected == 0 { resp.Code = 400 resp.Msg = "记录不存在" ctx.JSON(400, resp) return } } else { res := db.Scopes(models.Paginate(page, pageSize)).Raw("SELECT * FROM flaws WHERE facility_id = ? "+ "UNION SELECT * FROM issues WHERE facility_id = ? "+ "UNION SELECT * FROM records WHERE facility_id = ? "+ "UNION SELECT * FROM qualities WHERE facility_id = ? "+ "UNION SELECT * FROM inspections WHERE facility_id = ?", "code", "code", "code", "code", "code").Find(&req) if res.RowsAffected == 0 { resp.Code = 400 resp.Msg = "记录不存在" ctx.JSON(400, resp) return } } resp.Data = req ctx.JSON(200, resp) } else if label < 1 || label > 4 { var req []*Total res := db.Scopes(models.Paginate(page, pageSize)).Raw("SELECT * FROM flaws WHERE label = ? "+ "UNION SELECT * FROM issues WHERE label = ? "+ "UNION SELECT * FROM records WHERE label = ? "+ "UNION SELECT * FROM qualities WHERE label = ? "+ "UNION SELECT * FROM inspections WHERE label = ?", "label", "label", "label", "label", "label").Find(&req) if res.RowsAffected == 0 { resp.Code = 400 resp.Msg = "记录不存在" ctx.JSON(400, resp) return } resp.Data = req ctx.JSON(200, resp) } else { ctx.JSON(400, models.Response{ Code: 400, Msg: "参数有误", }) return } }

以下是改进的代码：

func TracingList(ctx *gin.Context) {
    resp := models.Response{
        Code: 0,
        Msg:  "success",
    }

    code := ctx.Query("code")
    if len(code) == 0 {
        resp.Code = 400
        resp.Msg = "请输入code值"
        ctx.JSON(400, resp)
        return
    }

    t, err := strconv.Atoi(ctx.Query("t"))
    if err != nil || t < 0 || t > 5 {
        resp.Code = 400
        resp.Msg = "无效的参数t"
        ctx.JSON(400, resp)
        return
    }

    label, err := strconv.Atoi(ctx.Query("label"))
    if err != nil || label < 1 || label > 4 {
        resp.Code = 400
        resp.Msg = "无效的参数label"
        ctx.JSON(400, resp)
        return
    }

    page, err := strconv.Atoi(ctx.DefaultQuery("page", "1"))
    if err != nil || page < 1 {
        resp.Code = 400
        resp.Msg = "无效的参数page"
        ctx.JSON(400, resp)
        return
    }

    pageSize, err := strconv.Atoi(ctx.DefaultQuery("pageSize", "10"))
    if err != nil || pageSize < 1 {
        resp.Code = 400
        resp.Msg = "无效的参数pageSize"
        ctx.JSON(400, resp)
        return
    }

    var req interface{}
    switch t {
    case 0:
        req = []*Total{}
    case 1:
        req = []*models.Flaw{}
    case 2:
        req = []*models.Issue{}
    case 3:
        req = []*models.Record{}
    case 4:
        req = []*models.Quality{}
    case 5:
        req = []*models.Inspection{}
    }

    db := common.DB.Session(&gorm.Session{})
    res := db.Scopes(models.Paginate(page, pageSize)).Where("facility_id=?", code)
    if t >= 1 && t <= 5 {
        res = res.Table("flaws").Where("facility_id=?", code).
            Or("facility_id=?", code).
            Or("facility_id=?", code).
            Or("facility_id=?", code).
            Or("facility_id=?", code)
    }
    res.Find(req)
    if res.RowsAffected == 0 {
        resp.Code = 400
        resp.Msg = "记录不存在"
        ctx.JSON(400, resp)
        return
    }

    resp.Data = req
    ctx.JSON(200, resp)
}

主要改进包括：

1. 对输入的参数进行了有效性检查，如 t、label、page 和 pageSize 都需要为正整数，code 不能为空。
2. 使用了 Go 语言内置的错误处理机制，当参数无效时，返回错误信息。
3. 将 SQL 查询语句拆分为两段，根据 t 的值判断使用哪一段，避免了使用 Raw() 方法的安全隐患。
4. 代码结构更加清晰，易于阅读和维护。