优化代码 return simObjList.stream() .filter(o -> !tableNameWithColumnNameList.contains(o.getTableName() + PqlConst.COLUMN_SPLIT + o.getColumn().getTitle())) .collect(Collectors.toList());
时间: 2024-03-21 12:38:28 浏览: 12
这段代码可以进一步优化。可以考虑将 `tableNameWithColumnNameList` 转换为 Set,这样可以提高 `contains` 方法的查找速度。另外,在 lambda 中使用 `+` 运算符拼接字符串会创建大量的临时对象,可以改为使用 `String.join` 方法。优化后的代码如下所示:
```
Set<String> tableNameWithColumnNameSet = new HashSet<>(tableNameWithColumnNameList);
return simObjList.stream()
.filter(o -> !tableNameWithColumnNameSet.contains(String.join(PqlConst.COLUMN_SPLIT, o.getTableName(), o.getColumn().getTitle())))
.collect(Collectors.toList());
```
相关问题
优化代码 private void addReferencedKpi(List<SimulationTableDto> list, List<QueryCodeVo> codeList, List<Map<String, List<String>>> referencedList) { if (CollectionUtils.isEmpty(list) || CollectionUtils.isEmpty(codeList) || CollectionUtils.isEmpty(referencedList)) { return; } // 转换结构 key1-table key2-column value-codeList Map<String, Map<String, List<String>>> tableColumnWithCodeListMap = Maps.newHashMap(); IntStream.range(0, codeList.size()).forEach(i -> { CodeVo codeVo = codeList.get(i).getCode(); String title = codeVo.getTitle(); Map<String, List<String>> referencedPerMap = referencedList.get(i); if (MapUtils.isEmpty(referencedPerMap)) { return; } referencedPerMap.forEach((table, columns) -> { String reversedTable = table; // case表别名去掉case后缀 if (reversedTable.endsWith(PqlConst.CASES_TABLE_NAME_SUFFIX)) { reversedTable = reversedTable.substring(0, reversedTable.length() - PqlConst.CASES_TABLE_NAME_SUFFIX.length()); } tableColumnWithCodeListMap.computeIfAbsent(reversedTable, k -> Maps.newHashMap()); String finalReversedTable = reversedTable; columns.forEach(column -> tableColumnWithCodeListMap.get(finalReversedTable).computeIfAbsent(column, k -> Lists.newArrayList()).add(title)); }); }); list.forEach(simulationTableDto -> { String simTableName = simulationTableDto.getTableName(); String simTitle = simulationTableDto.getColumn().getTitle(); tableColumnWithCodeListMap.computeIfPresent(simTableName, (table, columnMap) -> { if (columnMap.containsKey(simTitle)) { simulationTableDto.getColumn().setReferencedKpis(columnMap.get(simTitle)); } return columnMap; }); }); }
这段代码已经很简洁了,但还有一些可以改进的地方。首先,可以使用 Stream 的方式来实现对 QueryCodeVo 列表的遍历,这样可以更加简洁地实现相同的逻辑。其次,可以将对 tableColumnWithCodeListMap 的操作提取为一个方法,这样可以使代码更加清晰。以下是优化后的代码:
```
private void addReferencedKpi(List<SimulationTableDto> list, List<QueryCodeVo> codeList, List<Map<String, List<String>>> referencedList) {
if (CollectionUtils.isEmpty(list) || CollectionUtils.isEmpty(codeList) || CollectionUtils.isEmpty(referencedList)) {
return;
}
Map<String, Map<String, List<String>>> tableColumnWithCodeListMap = new HashMap<>();
codeList.stream()
.map(QueryCodeVo::getCode)
.forEach(codeVo -> {
String title = codeVo.getTitle();
Map<String, List<String>> referencedPerMap = referencedList.get(codeList.indexOf(new QueryCodeVo(codeVo)));
if (MapUtils.isEmpty(referencedPerMap)) {
return;
}
referencedPerMap.forEach((table, columns) -> {
String reversedTable = table.endsWith(PqlConst.CASES_TABLE_NAME_SUFFIX) ? table.substring(0, table.length() - PqlConst.CASES_TABLE_NAME_SUFFIX.length()) : table;
addReferencedKpiToMap(reversedTable, columns, title, tableColumnWithCodeListMap);
});
});
list.forEach(simulationTableDto -> {
String simTableName = simulationTableDto.getTableName();
String simTitle = simulationTableDto.getColumn().getTitle();
tableColumnWithCodeListMap.computeIfPresent(simTableName, (table, columnMap) -> {
if (columnMap.containsKey(simTitle)) {
simulationTableDto.getColumn().setReferencedKpis(columnMap.get(simTitle));
}
return columnMap;
});
});
}
private void addReferencedKpiToMap(String reversedTable, List<String> columns, String title, Map<String, Map<String, List<String>>> tableColumnWithCodeListMap) {
tableColumnWithCodeListMap.computeIfAbsent(reversedTable, k -> new HashMap<>());
columns.forEach(column -> tableColumnWithCodeListMap.get(reversedTable)
.computeIfAbsent(column, k -> new ArrayList<>()).add(title));
}
```
优化后的代码使用了 Stream 对 QueryCodeVo 列表进行遍历,使用了一个额外的方法 addReferencedKpiToMap 来添加 KPI 到 tableColumnWithCodeListMap。这样代码更加清晰和简洁。
优化代码 private List<SimulationTableDto> filteredSimObjList(List<SimulationTableDto> simRootList, List<SimulationTableDto> simObjList) { if (CollectionUtils.isEmpty(simObjList) || CollectionUtils.isEmpty(simRootList)) { return Lists.newArrayList(); } List<SimulationTableDto> filteredSimObjList = Lists.newArrayList(); for (SimulationTableDto simObjColumn : simObjList) { int checkInt = 0; String s1 = simObjColumn.getTableName() + PqlConst.VARIANT_DELIMETER + simObjColumn.getColumn().getTitle(); for (SimulationTableDto simRootColumn : simRootList) { String s2 = simRootColumn.getTableName() + PqlConst.VARIANT_DELIMETER + simRootColumn.getColumn().getTitle(); if (s1.equals(s2)) { checkInt = checkInt + 1; break; } } if (checkInt == 0) { filteredSimObjList.add(simObjColumn); } } return filteredSimObjList; }
可以通过使用 Java 8 的 Stream API 来优化这段代码,使其更加简洁和易读。重写后的代码如下所示:
```
private List<SimulationTableDto> filteredSimObjList(List<SimulationTableDto> simRootList, List<SimulationTableDto> simObjList) {
if (CollectionUtils.isEmpty(simObjList) || CollectionUtils.isEmpty(simRootList)) {
return Lists.newArrayList();
}
return simObjList.stream()
.filter(simObjColumn -> simRootList.stream()
.noneMatch(simRootColumn -> (simObjColumn.getTableName() + PqlConst.VARIANT_DELIMETER + simObjColumn.getColumn().getTitle())
.equals(simRootColumn.getTableName() + PqlConst.VARIANT_DELIMETER + simRootColumn.getColumn().getTitle())))
.collect(Collectors.toList());
}
```
这段代码利用了 Java 8 的 Stream API,使用了 filter 和 noneMatch 方法来过滤出符合条件的元素。其中,filter 方法用于过滤 simObjList 中的元素,noneMatch 方法用于判断 simRootList 中是否存在与过滤条件相匹配的元素。最终,使用 collect 方法将过滤后的结果收集到一个列表中并返回。