可以帮我将下面的代码优化一下吗?优化的示例写一下 private String getContent(CommonTaskSaveDTO taskSaveDTO, TaskGroup group, StringBuilder sb) { String name = getStr(group.getName()); if (!taskSaveDTO.getName().equals(name)) { sb.append("任务名称:").append(name).append(","); sb.append("任务名称:").append(taskSaveDTO.getName()).append(","); } if (taskSaveDTO.getTaskValidTime().compareTo(group.getTaskValidTime()) != 0) { sb.append("任务生效时间:").append(group.getTaskValidTime()).append(","); sb.append("任务生效时间:").append(taskSaveDTO.getTaskValidTime()).append(","); } if (taskSaveDTO.getTaskInvalidTime().compareTo(group.getTaskInvalidTime()) != 0) { sb.append("任务失效时间:").append(group.getTaskInvalidTime()).append(","); sb.append("任务生效时间:").append(taskSaveDTO.getTaskInvalidTime()).append(","); } String info = group.getInfo(); if (!taskSaveDTO.getInfo().equals(info)) { sb.append("任务说明:").append(getStr(info)).append(","); sb.append("任务说明:").append(taskSaveDTO.getInfo()).append(","); } //查询任务组和任务关联表 TaskGroupListDetailDTO detailDTO = taskGroupRelationService.queryTaskGroupRelationDetailList(group.getCode()); if (detailDTO == null) { return sb.deleteCharAt(sb.length() - 1).toString(); } String taskPurpose = CollectionUtils.isEmpty(taskSaveDTO.getTaskPurposes()) ? "" : String.join(",", taskSaveDTO.getTaskPurposes()); if (!taskPurpose.equals(detailDTO.getTaskPurpose())) { String newPurpose = getPurpose(taskPurpose); String oldPurpose = getPurpose(detailDTO.getTaskPurpose()); sb.append("任务目的:").append(getStr(oldPurpose)).append(","); sb.append("任务目的:").append(newPurpose).append(","); } //获取到用户身份 String join = StringUtils.join(taskSaveDTO.getUserIdentityList(), ","); String userIdentity = detailDTO.getUserIdentity(); if (!join.equals(userIdentity)) { sb.append("用户身份:").append("(").append(getStr(userIdentity)).append(")").append(","); sb.append("用户身份:").append("(").append(join).append(")").append(","); } String appCode = StringUtils.join(taskSaveDTO.getAppCodes(), ","); String appCode1 = detailDTO.getAppCode(); if (!appCode.equals(appCode1)) { sb.append("归属平台:").append("(").append(getStr(appCode1)).append(")").append(","); sb.append("归属平台:").append("(").append(appCode).append(")").append(","); } String chanel = StringUtils.join(taskSaveDTO.getChannels(), ","); String channel = detailDTO.getChannel(); if (!chanel.equals(channel)) { sb.append("归属渠道:").append("(").append(getStr(channel)).append(")").append(","); sb.append("归属渠道:").append("(").append(chanel).append(")").append(","); } String department = StringUtils.join(taskSaveDTO.getDepartments(), ","); String department1 = detailDTO.getDepartment(); if (!department.equals(department1)) { sb.append("归属渠道:").append("(").append(getStr(department1)).append(")").append(","); sb.append("归属渠道:").append("(").append(department).append(")").append(","); } if (!taskSaveDTO.getTaskState().equals(detailDTO.getTaskState())) { sb.append("启用/禁用:").append(Objects.requireNonNull(CommonBusinessEnum.TaskStateEnum.ofByValue(detailDTO.getTaskState())).getName()).append(","); sb.append("启用/禁用:").append(Objects.requireNonNull(CommonBusinessEnum.TaskStateEnum.ofByValue(taskSaveDTO.getTaskState())).getName()).append(","); } if(taskSaveDTO.getType().equals(CommonBusinessEnum.TaskTypeEnum.YDWZ.getValue())){ //判断阅读文章 readeRule(taskSaveDTO, sb, detailDTO); }else { //判断签到规则 checkRule(taskSaveDTO, sb, detailDTO); } if (sb.length() != 0) { return sb.deleteCharAt(sb.length() - 1).toString(); } return ""; }
时间: 2023-02-07 18:48:19 浏览: 62
我们可以考虑以下几点优化建议:
1. 将所有的比较操作放在一起,避免重复执行。
2. 将每次比较的结果存储在一个布尔变量中,然后在所有比较操作结束后一次性处理结果。
3. 将对字符串的非空判断和转换为空字符串的操作提取到一个独立的方法中,方便调用。
4. 将每次比较操作中的重复字符串提取出来,用一个变量表示。
按照上述优化建议,我们可以将代码改写为如下形式:
```
private String getContent(CommonTaskSaveDTO taskSaveDTO, TaskGroup group, StringBuilder sb) {
boolean nameChanged = !taskSaveDTO.getName().equals(getStr(group.getName()));
boolean taskValidTimeChanged = taskSaveDTO.getTaskValidTime().compareTo(group.getTaskValidTime()) != 0;
boolean taskInvalidTimeChanged = taskSaveDTO.getTaskInvalidTime().compareTo(group.getTaskInvalidTime()) != 0;
boolean infoChanged = !taskSaveDTO.getInfo().equals(getStr(group.getInfo()));
TaskGroupListDetailDTO detailDTO = taskGroupRelationService.queryTaskGroupRelationDetailList(group.getCode());
String taskPurpose = StringUtils.join(taskSaveDTO.getTaskPurposes(), ",");
boolean taskPurposeChanged = !taskPurpose.equals(getStr(detailDTO.getTaskPurpose()));
String join = StringUtils.join(taskSaveDTO.getUserIdentityList(), ",");
boolean userIdentityChanged = !join.equals(getStr(detailDTO.getUserIdentity()));
String appCode = StringUtils.join(taskSaveDTO.getAppCodes(), ",");
boolean appCodeChanged = !appCode.equals(getStr(detailDTO.getAppCode()));
String chanel = StringUtils.join(taskSaveDTO.getChannels(), ",");
boolean channelChanged = !chanel.equals(getStr(detailDTO.getChannel()));