public AjaxResult importData(MultipartFile file, SysDept sysDept) throws Exception { ExcelUtil<SysDept> util = new ExcelUtil<>(SysDept.class); List<SysDept> sysDeptList = util.importExcel(file.getInputStream(), 1); sysDept.setDeptType(Constants.DEPT_BANK); sysDept.setDelFlag(Constants.STATUS_VALID); List<SysDept> depts = deptService.selectDeptList(sysDept); // 创建机构名称集合 List<String> deptNames = new ArrayList<>(); // 创建机构编号集合 List<String> deptNum = new ArrayList<>(); // 创建父部门编号map Map<String, SysDept> parentNum = new HashMap<>(); for (SysDept dept : depts) { deptNames.add(dept.getDeptName()); deptNum.add(dept.getDeptNum()); parentNum.put(dept.getDeptNum(), dept); } for (SysDept dept : sysDeptList) { if (deptNames.contains(dept.getDeptName()) || deptNum.contains(dept.getDeptNum())) { throw new ServiceException("机构已存在!"); } // 添加父部门id if (parentNum.get(dept.getParentNum()) != null) { dept.setParentId(parentNum.get(dept.getParentNum()).getDeptId()); deptNames.add(dept.getDeptName()); parentNum.put(dept.getDeptNum(), dept); deptNum.add(dept.getDeptNum()); } else { throw new ServiceException("添加" + dept.getDeptName() + "失败!经办机构不存在!"); } dept.setDeptType(Constants.DEPT_BANK); dept.setCreateBy(getUserId()); dept.setStatus(Constants.STATUS_VALID); dept.setDelFlag(Constants.STATUS_VALID); //存储用户信息 SysUser user = new SysUser(); user.setUserName(dept.getUserName()); user.setPassword(SecurityUtils.encryptPassword(dept.getPassword())); user.setPhonenumber(dept.getPhonenumber()); user.setRoleIds(dept.getRoleIds()); user.setUserType(Constants.USER_TYPE_BANK); user.setCreateBy(getUserId()); user.setStatus(Constants.STATUS_VALID); user.setDelFlag(Constants.STATUS_VALID); if (!userService.checkUserNameUnique(user)) { throw new ServiceException(ADD_USER + user.getUserName() + ACCOUNT_ALREADY_EXISTS); } else if (StringUtils.isNotEmpty(user.getPhonenumber()) && !userService.checkPhoneUnique(user)) { throw new ServiceException(ADD_USER + user.getUserName() + PHONE_EXISTS); } userService.insertUser(user); //存储部门信息 dept.setUserId(user.getUserId()); deptService.insertDept(dept); //更新用户信息 user.setDeptId(dept.getDeptId()); userService.updateUser(user); } return success(); }重构这段代码 将其认知复杂度从16降低到允许的15。
时间: 2024-02-14 15:12:57 浏览: 144
为了将代码的认知复杂度从16降低到15,可以考虑进行以下重构:
1. 将创建机构名称集合、创建机构编号集合和创建父部门编号map的部分代码提取为单独的方法,以减少importData方法中的代码量。
2. 将判断机构是否存在的部分代码提取为单独的方法,以减少importData方法中的代码量。
3. 将存储用户信息、存储部门信息和更新用户信息的部分代码提取为单独的方法,以减少importData方法中的代码量。
重构后的代码如下:
```
public AjaxResult importData(MultipartFile file, SysDept sysDept) throws Exception {
ExcelUtil<SysDept> util = new ExcelUtil<>(SysDept.class);
List<SysDept> sysDeptList = util.importExcel(file.getInputStream(), 1);
sysDept.setDeptType(Constants.DEPT_BANK);
sysDept.setDelFlag(Constants.STATUS_VALID);
List<SysDept> depts = deptService.selectDeptList(sysDept);
Map<String, SysDept> parentNum = createParentNumMap(depts);
List<String> deptNames = createDeptNames(depts);
List<String> deptNum = createDeptNum(depts);
for (SysDept dept : sysDeptList) {
if (isDeptExist(deptNames, deptNum, dept)) {
throw new ServiceException("机构已存在!");
}
if (parentNum.get(dept.getParentNum()) != null) {
dept.setParentId(parentNum.get(dept.getParentNum()).getDeptId());
deptNames.add(dept.getDeptName());
parentNum.put(dept.getDeptNum(), dept);
deptNum.add(dept.getDeptNum());
} else {
throw new ServiceException("添加" + dept.getDeptName() + "失败!经办机构不存在!");
}
storeUserInfoAndDeptInfo(dept);
}
return success();
}
private Map<String, SysDept> createParentNumMap(List<SysDept> depts) {
Map<String, SysDept> parentNum = new HashMap<>();
for (SysDept dept : depts) {
parentNum.put(dept.getDeptNum(), dept);
}
return parentNum;
}
private List<String> createDeptNames(List<SysDept> depts) {
List<String> deptNames = new ArrayList<>();
for (SysDept dept : depts) {
deptNames.add(dept.getDeptName());
}
return deptNames;
}
private List<String> createDeptNum(List<SysDept> depts) {
List<String> deptNum = new ArrayList<>();
for (SysDept dept : depts) {
deptNum.add(dept.getDeptNum());
}
return deptNum;
}
private boolean isDeptExist(List<String> deptNames, List<String> deptNum, SysDept dept) {
return deptNames.contains(dept.getDeptName()) || deptNum.contains(dept.getDeptNum());
}
private void storeUserInfoAndDeptInfo(SysDept dept) {
SysUser user = createSysUser(dept);
if (userService.checkUserNameUnique(user)) {
if (StringUtils.isNotEmpty(user.getPhonenumber()) && userService.checkPhoneUnique(user)) {
userService.insertUser(user);
dept.setUserId(user.getUserId());
deptService.insertDept(dept);
user.setDeptId(dept.getDeptId());
userService.updateUser(user);
} else {
throw new ServiceException(ADD_USER + user.getUserName() + PHONE_EXISTS);
}
} else {
throw new ServiceException(ADD_USER + user.getUserName() + ACCOUNT_ALREADY_EXISTS);
}
}
private SysUser createSysUser(SysDept dept) {
SysUser user = new SysUser();
user.setUserName(dept.getUserName());
user.setPassword(SecurityUtils.encryptPassword(dept.getPassword()));
user.setPhonenumber(dept.getPhonenumber());
user.setRoleIds(dept.getRoleIds());
user.setUserType(Constants.USER_TYPE_BANK);
user.setCreateBy(getUserId());
user.setStatus(Constants.STATUS_VALID);
user.setDelFlag(Constants.STATUS_VALID);
return user;
}
```
阅读全文