if (entity != null && entity.isStatistics()) { Double temp = 0D; if (!statistics.containsKey(index)) { statistics.put(index, temp); } try { temp = Double.valueOf(text); } catch (NumberFormatException e) { } statistics.put(index, statistics.get(index) + temp); }将"Map.containsKey()"替换为对"Map.computeIfAbsent()"的调用。
时间: 2024-02-14 22:15:20 浏览: 31
当使用`Map.computeIfAbsent()`时,可以避免进行多次访问`Map`,提高代码效率。下面是替换后的代码:
```
if (entity != null && entity.isStatistics()) {
try {
Double temp = Double.valueOf(text);
statistics.computeIfAbsent(index, k -> 0D);
statistics.compute(index, (k, v) -> v + temp);
} catch (NumberFormatException e) {
//处理异常
}
}
```
使用`computeIfAbsent()`方法可以在`Map`中没有与给定键相关联的值时,执行给定的计算并将其结果插入到Map中。这样可以避免多次访问Map,提高了性能。同时,在这里,我们还使用`compute()`方法来更新Map中的值,避免了多次访问Map的开销。
相关问题
优化代码 参考 if (cstemp.combos != null && cstemp.combos.Count > 0) { List<BCD_COMBO_ITEMEntity> _ITEMEntities_Yes = new BCD_COMBO_ITEM().GetItemList( String.Format("COMBOGUID IN ({0})", String.Join(",", cstemp.combos.Select(x => "'" + x.GUID + "'").Distinct()))); if (_ITEMEntities_Yes != null && _ITEMEntities_Yes.Count > 0) { List<BCD_COMBO_ITEMEntity> _ITEMEntities_No = (cstemp.Nocombos != null && cstemp.Nocombos.Count > 0) ? new BCD_COMBO_ITEM().GetItemList( String.Format("COMBOGUID IN ({0})", String.Join(",", cstemp.combos.Select(x => "'" + x.GUID + "'").Distinct()))) : null; string _ITEMEntities_YesString = String.Join(",", _ITEMEntities_Yes.Select(x => x.ITEMGUID ).Distinct()); string _ITEMEntities_NoString = (_ITEMEntities_No != null && _ITEMEntities_No.Count > 0)? String.Join(",", _ITEMEntities_No.Select(x => x.ITEMGUID).Distinct()):""; List<BCB_CHECKSUBEntity> subTempsno = !string.IsNullOrWhiteSpace(_ITEMEntities_NoString) ? _CHECKSUBEntities.Where(x => _ITEMEntities_NoString.Contains(x.ITEMGUID)).ToList() : null; string subTempsnoString = (subTempsno != null && subTempsno.Count > 0) ? String.Join(",", subTempsno.Select(x => x.MAINGUID).Distinct()):""; List < BCB_CHECKMAINEntity > mainsTemps = _CHECKMAINEntitys.ToList().Where(r => ((cstemp.ageb > 0 || cstemp.agee > 0) ? (r.AGE >= cstemp.ageb && r.AGE <= cstemp.agee) : true) && (!string.IsNullOrWhiteSpace(subTempsnoString) ? (cstemp.bothagree == "True" ? subTempsnoString.Contains(r.GUID): !subTempsnoString.Contains(r.GUID)) : true)).ToList(); string mainguidstring = (mainsTemps != null && mainsTemps.Count > 0) ? String.Join(",", mainsTemps.Select(x => x.GUID).Distinct()) : ""; List <BCB_CHECKSUBEntity> subTemps = _CHECKSUBEntities.Where(x => !string.IsNullOrWhiteSpace(x.RESULT) && _ITEMEntities_YesString.Contains(x.ITEMGUID) && mainguidstring.Contains(x.MAINGUID)).ToList(); if (subTemps != null ) { drAuto[cstemp.CSName] = subTemps.Select(x => x.MAINGUID).Distinct().Count(); } } }
以下是我优化后的代码:
if (cstemp.combos != null && cstemp.combos.Any())
{
var comboGuids = cstemp.combos.Select(x => x.GUID).Distinct().Select(x => $"'{x}'");
var itemEntitiesYes = new BCD_COMBO_ITEM().GetItemList($"COMBOGUID IN ({string.Join(",", comboGuids)})");
if (itemEntitiesYes != null && itemEntitiesYes.Any())
{
List<BCD_COMBO_ITEMEntity> itemEntitiesNo = null;
if (cstemp.Nocombos != null && cstemp.Nocombos.Any())
{
var noComboGuids = cstemp.Nocombos.Select(x => x.GUID).Distinct().Select(x => $"'{x}'");
itemEntitiesNo = new BCD_COMBO_ITEM().GetItemList($"COMBOGUID IN ({string.Join(",", noComboGuids)})");
}
var itemEntitiesYesString = string.Join(",", itemEntitiesYes.Select(x => x.ITEMGUID).Distinct());
var itemEntitiesNoString = itemEntitiesNo != null && itemEntitiesNo.Any() ? string.Join(",", itemEntitiesNo.Select(x => x.ITEMGUID).Distinct()) : "";
var subTempsNo = !string.IsNullOrWhiteSpace(itemEntitiesNoString) ? _CHECKSUBEntities.Where(x => itemEntitiesNoString.Contains(x.ITEMGUID)).ToList() : null;
var subTempsNoString = subTempsNo != null && subTempsNo.Any() ? string.Join(",", subTempsNo.Select(x => x.MAINGUID).Distinct()) : "";
var mainsTemps = _CHECKMAINEntitys.ToList().Where(r =>
(cstemp.ageb > 0 || cstemp.agee > 0) ? (r.AGE >= cstemp.ageb && r.AGE <= cstemp.agee) : true &&
(string.IsNullOrWhiteSpace(subTempsNoString) || (cstemp.bothagree == "True" ? !subTempsNoString.Contains(r.GUID) : subTempsNoString.Contains(r.GUID)))
).ToList();
var mainguidstring = mainsTemps.Any() ? string.Join(",", mainsTemps.Select(x => x.GUID).Distinct()) : "";
var subTemps = _CHECKSUBEntities.Where(x => !string.IsNullOrWhiteSpace(x.RESULT) && itemEntitiesYesString.Contains(x.ITEMGUID) && mainguidstring.Contains(x.MAINGUID)).ToList();
if (subTemps != null)
{
drAuto[cstemp.CSName] = subTemps.Select(x => x.MAINGUID).Distinct().Count();
}
}
}
我主要做了以下几个优化:
1. 使用 Any() 方法替代 Count > 0,可以提高代码的可读性和性能。
2. 使用 var 关键字来声明变量,可以让代码更简洁。
3. 将字符串拼接操作移到变量声明处,可以提高可读性和代码复用性。
4. 将多个判断条件整合到一起,可以提高代码的简洁性和可读性。
protected virtual void OnShowEntitySuccess(object sender, GameEventArgs e) { ShowEntitySuccessEventArgs args = e as ShowEntitySuccessEventArgs; UserEntityData entityData = args.UserData as UserEntityData; if(entityData != null && entityData.HotLogicTypeName == typeof(MyAircraft).Name) m_MyAircraft = entityData.RuntimeEntity.HotLogicInstance as MyAircraft; }
这是C#语言中的一个虚方法,它是一个事件处理器,当一个实体成功地被显示到游戏场景中时,就会被调用。这个方法首先将事件参数转换为ShowEntitySuccessEventArgs类型,然后检查用户数据是否是UserEntityData类型,并且逻辑类型名称是否与MyAircraft类型名称相同。如果是,就将MyAircraft实例赋值给成员变量m_MyAircraft。