class UserSigninLog(db.Model): """登录日志表""" bind_key = 'db2' tablename = 'user_signin_log' id = mapped_column(Integer, primary_key=True) userid = mapped_column(String(16), index=True) username = mapped_column(String(32)) ip_addr = mapped_column(String(32)) request_user_agent = mapped_column(String(256)) c_date = mapped_column(DateTime) @staticmethod def add_user_signin_log(userid: str, username: str): """新增登录日志""" user_signin_log = UserSigninLog() user_signin_log.userid = userid user_signin_log.username = username user_signin_log.ip_addr = request.access_route[0] user_signin_log.request_user_agent = request.headers.get("User-Agent") user_signin_log.c_date = datetime.now() db.session.add(user_signin_log) db.session.commit() return True @staticmethod def check_ip_and_header_within_x_days(userid: str, days=7): """检查x天内登录过的ip地址和请求头""" sql_query = select(UserSigninLog) \ .where(UserSigninLog.userid == userid, UserSigninLog.ip_addr == request.access_route[0], UserSigninLog.request_user_agent == request.headers.get("User-Agent"), UserSigninLog.c_date >= datetime.now() - timedelta(days=days)).limit(1) user_ip_addr_log = db.session.execute(sql_query).scalar_one_or_none() if user_ip_addr_log: return True return False 请帮我建议并优化这段代码，python3.8

以下是我对这段代码的建议和优化：

1. 使用 Flask 的上下文对象获取 request 对象，避免在静态方法中使用全局变量

from flask import request

class UserSigninLog(db.Model):
    # ...

    @staticmethod
    def add_user_signin_log(userid: str, username: str):
        """新增登录日志"""
        user_signin_log = UserSigninLog()
        user_signin_log.userid = userid
        user_signin_log.username = username
        user_signin_log.ip_addr = request.access_route[0]
        user_signin_log.request_user_agent = request.headers.get("User-Agent")
        user_signin_log.c_date = datetime.now()
        db.session.add(user_signin_log)
        db.session.commit()
        return True

    @staticmethod
    def check_ip_and_header_within_x_days(userid: str, days=7):
        """检查x天内登录过的ip地址和请求头"""
        user_agent = request.headers.get("User-Agent")
        ip_addr = request.access_route[0]
        c_date = datetime.now() - timedelta(days=days)
        user_ip_addr_log = UserSigninLog.query.filter_by(userid=userid, ip_addr=ip_addr, request_user_agent=user_agent).filter(UserSigninLog.c_date >= c_date).first()
        if user_ip_addr_log:
            return True
        return False

2. 使用 SQLAlchemy 的 ORM 语法查询，避免手写 SQL 语句

from sqlalchemy import and_

class UserSigninLog(db.Model):
    # ...

    @staticmethod
    def check_ip_and_header_within_x_days(userid: str, days=7):
        """检查x天内登录过的ip地址和请求头"""
        user_agent = request.headers.get("User-Agent")
        ip_addr = request.access_route[0]
        c_date = datetime.now() - timedelta(days=days)
        user_ip_addr_log = UserSigninLog.query.filter(and_(UserSigninLog.userid == userid, UserSigninLog.ip_addr == ip_addr, UserSigninLog.request_user_agent == user_agent, UserSigninLog.c_date >= c_date)).first()
        if user_ip_addr_log:
            return True
        return False

3. 让静态方法更加灵活，接收 request 对象作为参数

class UserSigninLog(db.Model):
    # ...

    @staticmethod
    def add_user_signin_log(userid: str, username: str, request):
        """新增登录日志"""
        user_signin_log = UserSigninLog()
        user_signin_log.userid = userid
        user_signin_log.username = username
        user_signin_log.ip_addr = request.access_route[0]
        user_signin_log.request_user_agent = request.headers.get("User-Agent")
        user_signin_log.c_date = datetime.now()
        db.session.add(user_signin_log)
        db.session.commit()
        return True

    @staticmethod
    def check_ip_and_header_within_x_days(userid: str, request, days=7):
        """检查x天内登录过的ip地址和请求头"""
        user_agent = request.headers.get("User-Agent")
        ip_addr = request.access_route[0]
        c_date = datetime.now() - timedelta(days=days)
        user_ip_addr_log = UserSigninLog.query.filter(and_(UserSigninLog.userid == userid, UserSigninLog.ip_addr == ip_addr, UserSigninLog.request_user_agent == user_agent, UserSigninLog.c_date >= c_date)).first()
        if user_ip_addr_log:
            return True
        return False

这些是我对这段代码的建议和优化，希望能对你有所帮助。