优化一下代码static void fill_file_chunk(const char *path, int *number, int level) { DIR *dir = NULL; struct dirent *entry = NULL; int i = 0; ++level; if(level > 3) return; dir = opendir(path); if(dir == NULL) return; while((entry = readdir(dir)) != NULL) { if(strcmp(entry->d_name, ".") == 0 || strcmp(entry->d_name, "..") == 0) continue; if(entry->d_type == 4 && level == 1){ if(check_dir_name(entry->d_name) == 0) continue; char buffer[MAX_PATH]; sprintf(buffer, "%s/%s", path, entry->d_name); fill_file_chunk(buffer, number, level); } if(entry->d_type == 4 && level == 2){ if(check_dir_name(entry->d_name) == 0) continue; char buffer[MAX_PATH]; sprintf(buffer, "%s/%s", path, entry->d_name); fill_file_chunk(buffer, number, level); } if(entry->d_type == 8 && level ==3){ if(check_file_name(entry->d_name) == 0) continue; if(*number == max_file_chunk){ file_chunks = (struct FileChunk *)realloc(file_chunks, (max_file_chunk + FILE_CHUNK_INCREAMENT) * sizeof(struct FileChunk)); if(file_chunks == NULL) break; max_file_chunk += FILE_CHUNK_INCREAMENT; } char buffer[MAX_PATH]; sprintf(buffer, "%s/%s", path, entry->d_name); i = *number; strcpy(file_chunks[i].file_name, entry->d_name); sprintf(file_chunks[i].file_path, buffer); file_chunks[i].file_size = get_file_size(buffer); *number = i + 1; } else continue; } closedir(dir); return; }
时间: 2024-01-18 17:02:20 浏览: 23
Here are some suggested optimizations for the given code:
1. Use switch case instead of if-else: In the current code, multiple if-else statements are being used to check for different conditions. This can be optimized by using switch case instead, which can improve readability and maintainability of the code.
2. Use early return to reduce nested if-else: In the current code, multiple if-else statements are nested inside a while loop, which can make the code difficult to read and understand. By using early return, we can reduce the level of nesting and make the code more readable.
3. Avoid redundant code: In the current code, there are multiple instances where the same block of code is being repeated. This can be optimized by refactoring the code and avoiding the duplication of code.
Here is the optimized code:
```
static void fill_file_chunk(const char *path, int *number, int level) {
DIR *dir = opendir(path);
if(dir == NULL) {
return;
}
++level;
if(level > 3) {
closedir(dir);
return;
}
struct dirent *entry;
while((entry = readdir(dir)) != NULL) {
switch(entry->d_type) {
case DT_DIR:
if(level == 1 || level == 2) {
if(check_dir_name(entry->d_name) == 0) {
continue;
}
char buffer[MAX_PATH];
sprintf(buffer, "%s/%s", path, entry->d_name);
fill_file_chunk(buffer, number, level);
}
break;
case DT_REG:
if(level == 3) {
if(check_file_name(entry->d_name) == 0) {
continue;
}
if(*number == max_file_chunk) {
file_chunks = (struct FileChunk *)realloc(file_chunks, (max_file_chunk + FILE_CHUNK_INCREAMENT) * sizeof(struct FileChunk));
if(file_chunks == NULL) {
break;
}
max_file_chunk += FILE_CHUNK_INCREAMENT;
}
char buffer[MAX_PATH];
sprintf(buffer, "%s/%s", path, entry->d_name);
int i = *number;
strcpy(file_chunks[i].file_name, entry->d_name);
sprintf(file_chunks[i].file_path, buffer);
file_chunks[i].file_size = get_file_size(buffer);
*number = i + 1;
}
break;
default:
break;
}
}
closedir(dir);
}
```
This optimized code uses switch case instead of if-else statements, reduces the level of nesting by using early return, and avoids redundant code by refactoring the code.